On Thu, Apr 24, 2014 at 01:57:49PM +0930, Rusty Russell wrote: > Greg Kroah-Hartman <gre...@linuxfoundation.org> writes: > > On Tue, Apr 22, 2014 at 01:03:29PM +0930, Rusty Russell wrote: > >> In line with practice for module parameters, we're adding a build-time > >> check that sysfs files aren't world-writable. > > > > Then why not just use the __ATTR_RO() macro? > > Hmm, I didn't know those variants existed :( > > But most of these are not amenable to __ATTR_RO etc, since they call > generic helpers, eg: > > __ATTR(delimiters, S_IWUGO|S_IRUGO, punc_show, punc_store); > > I dislike the __ATTR_RO etc macros: hiding the references to the > function from grep is Too Much Magic. (Sure, I do it in module_param, > but that has the excuse that it allows typechecking as well). > > > I'd prefer some "standard" permissions for all of these sysfs files, > > it's quite confusing otherwise, don't you agree? > > Agreed. So I used S_IWUSR | S_IRUGO everywhere, which is what ATTR_RW > uses. > > Cheers, > Rusty. > > Subject: drivers/staging/speakup/: avoid world-writable sysfs files. > > In line with practice for module parameters, we're adding a build-time > check that sysfs files aren't world-writable. > > Cc: Christopher Brannon <ch...@the-brannons.com> > Cc: Samuel Thibault <samuel.thiba...@ens-lyon.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Signed-off-by: Rusty Russell <ru...@rustcorp.com.au>
Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
