On Wed, 30 Apr 2014 17:15:57 +0200 Mike Galbraith <umgwanakikb...@gmail.com> wrote:
> On Wed, 2014-04-30 at 11:11 -0400, Steven Rostedt wrote: > > > > Another little bug. This hunk of patches/stomp-machine-raw-lock.patch > > > should be while (atomic_read(&done.nr_todo)) > > > > > > @@ -647,7 +671,7 @@ int stop_machine_from_inactive_cpu(int ( > > > ret = multi_cpu_stop(&msdata); > > > > > > /* Busy wait for completion. */ > > > - while (!completion_done(&done.completion)) > > > + while (!atomic_read(&done.nr_todo)) > ^--- that ! needs to go away > > > > I don't see this in the code. That is, there is no "completion_done()" > > in stop_machine_from_inactive_cpu(). It is already an atomic_read(). > > Yes, but it should read "while (atomic_read(&done.nr_todo))" Ah, this would have been better if you had sent a patch. I misread what you talked about. Yes, this was the culprit of my failures. After removing the '!', it worked. Care to send a patch :-) -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
