On Wed, Apr 30, 2014 at 07:46:18PM +0800, ching wrote:
> + acb->pmuD = reg;
> + reg->chip_id = (u32 __iomem *)((unsigned long)acb->mem_base0 +
> + ARCMSR_ARC1214_CHIP_ID);
> + reg->cpu_mem_config = (u32 __iomem *)((unsigned long)
> + acb->mem_base0 + ARCMSR_ARC1214_CPU_MEMORY_CONFIGURATION);
These casts aren't needed because acb->mem_base0 is a void __iomem *.
You could just do:
reg->cpu_mem_config = acb->mem_base0 +
ARCMSR_ARC1214_CPU_MEMORY_CONFIGURATION;
Or you could change ARCMSR_ARC1214_CPU_MEMORY_CONFIGURATION to:
#define ARCMSR_ARC1214_CPU_MEMORY_CONFIGURATION(acb) (acb->mem_base0 + 0x00008)
So it would be:
reg->cpu_mem_config = ARCMSR_ARC1214_CPU_MEMORY_CONFIGURATION(acb);
> + reg->i2o_host_interrupt_mask = (u32 __iomem *)((unsigned long)
> + acb->mem_base0 + ARCMSR_ARC1214_I2_HOST_INTERRUPT_MASK);
> + reg->sample_at_reset = (u32 __iomem *)((unsigned long)
> + acb->mem_base0 + ARCMSR_ARC1214_SAMPLE_RESET);
> + reg->reset_request = (u32 __iomem *)((unsigned long)
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
