On 3 May 2014 05:46, Jonghwan Choi <jhbird.c...@samsung.com> wrote: > Hi. Viresh Kumar > Your reply is so fast like Usain Bolt.
Heh, that's not true.. See how slow I was this time :) >> So, create three flags: >> OPP_TABLE_ORDER_ASCENDING 0 >> OPP_TABLE_ORDER_DESCENDING 1 >> OPP_TABLE_ORDER_ORIGINAL 2 (And use this for your case.) > > -> Actually, I want to use OPP_TABLE_ORDER_DESCENDING.(Not > OPP_TABLE_ORDER_ORIGINAL.) > I think that it is enough to support both descending and ascending ordering > only. > The meaning of "ORIGIANL" Amit, said, when he(and I) writes a frequency in > dts file with ordering(Ascending or Descending). He(and I) want the > frequency to be register according to ordering.(Ascending or Descending). But what if somebody doesn't have a ascending or descending list there? And want to preserve the original list? That's why I recommended it. > I concerned that if we use ORIGINAL ordering, opp_find_freq_ceil/foor can be > broken. I completely missed that earlier :) .. It would be broken with descending one as well.. To skip the complexity of finding right freq associated with "ORIGINAL" ordering, lets concentrate on Ascending/Descending ordering for now. So, this is what I would recommend now: - Create two macros: OPP_TABLE_ORDER_ASCENDING and OPP_TABLE_ORDER_DESCENDING - create of_init_opp_table_ordered(**, int order), order would be one of the above two macros - rename dev_pm_opp_add to __dev_pm_opp_add() and create a wrapper over it: dev_pm_opp_add(), which would pass OPP_TABLE_ORDER_ASCENDING to it by default and call it from of_init_opp_table_ordered() like this: __dev_pm_opp_add(***, order).. - Fix ceil/floor routines for these two cases. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
