On Wed, 7 May 2014, Joonsoo Kim wrote: > In free_block(), if freeing object makes new free slab and number of > free_objects exceeds free_limit, we start to destroy this new free slab > with holding the kmem_cache node lock. Holding the lock is useless and, > generally, holding a lock as least as possible is good thing. I never > measure performance effect of this, but we'd be better not to hold the lock > as much as possible. > > Commented by Christoph: > This is also good because kmem_cache_free is no longer called while > holding the node lock. So we avoid one case of recursion. > > Acked-by: Christoph Lameter <[email protected]> > Signed-off-by: Joonsoo Kim <[email protected]>
Acked-by: David Rientjes <[email protected]> Nice optimization. I think it could have benefited from a comment describing what the free_block() list formal is, though. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
