On Thu, May 08, 2014 at 04:56:30PM +0200, Arnd Bergmann wrote: > commit 2cce4be9e6b8 "regulator: arizona-ldo1: Add processing of init_data > from device tree" added a call to of_get_child_by_name() but > did not add an #include to the header file declaring that function. > > I got a build error when doing randconfig testing on this, which > is fixed by this patch to include of.h. > > drivers/regulator/arizona-ldo1.c:192:2: error: implicit declaration of > function 'of_get_child_by_name' [-Werror=implicit-function-declaration] > drivers/regulator/arizona-ldo1.c:193:2: error: implicit declaration of > function 'of_parse_phandle' [-Werror=implicit-function-declaration] > drivers/regulator/arizona-ldo1.c:213:2: error: implicit declaration of > function 'of_node_put' [-Werror=implicit-function-declaration] > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Cc: Charles Keepax <ckee...@opensource.wolfsonmicro.com> > Cc: Mark Brown <broo...@linaro.org> > ---
Thanks, yeah seems that is getting implicitly through another header included in my config. Will need a similar fix for arizona-micsupp, I will get one out for that. Reviewed-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/