On 08/05/2014 16:56, Arnd Bergmann : > Building the at91 adc driver with CONFIG_INPUT disabled results in this > build error: > > ERROR: "input_event" [drivers/iio/adc/at91_adc.ko] undefined! > ERROR: "input_unregister_device" [drivers/iio/adc/at91_adc.ko] undefined! > ERROR: "input_free_device" [drivers/iio/adc/at91_adc.ko] undefined! > ERROR: "input_register_device" [drivers/iio/adc/at91_adc.ko] undefined! > ERROR: "input_set_abs_params" [drivers/iio/adc/at91_adc.ko] undefined! > ERROR: "input_allocate_device" [drivers/iio/adc/at91_adc.ko] undefined! > > To make sure we can build random configurations, this turns on CONFIG_INPUT > whenever CONFIG_AT91_ADC is enabled.
Isn't it a "select" instead of "depends" that is required then? > Signed-off-by: Arnd Bergmann <[email protected]> > Cc: [email protected] > Cc: Josh Wu <[email protected]> > Cc: Jonathan Cameron <[email protected]> > Cc: Maxime Ripard <[email protected]> > --- > drivers/iio/adc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 90f596d..a80d236 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -110,6 +110,7 @@ config AD799X > config AT91_ADC > tristate "Atmel AT91 ADC" > depends on ARCH_AT91 > + depends on INPUT > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > select SYSFS > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
