On 05/11/2014 06:00 AM, Josef Gajdusek wrote:
Adds support for emc1412.

[ ... ]
@@ -330,9 +389,9 @@ static int emc1403_detect(struct i2c_client *client,
        }

        id = i2c_smbus_read_byte_data(client, THERMAL_REVISION_REG);
-       if (id != 0x01)
+       if (id != 0x01 && id != 0x04) {
                return -ENODEV;
-
+       }

Forgot: Please see Documents/CodingStyle, Chapter 3:

        "Do not unnecessarily use braces where a single statement will do."

As it turns out, this change generates a checkpatch warning.

Also, you forgot to sign this patch.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to