On 14 May 2014 15:01, Chander Kashyap <chander.kash...@linaro.org> wrote: >> say we do at this point: >> if (new_opp->rate == opp->rate) { >> dev_err(dev, "%s: attempt to add duplicate OPP entry (rate=%ld)\n", >> __func__, new_opp->rate) >> kfree(new_opp); >> return -EINVAL; >> } > > Yes this is more cleaner. > But instead of dev_err, we should use dev_warn and secondly
Correct > return 0 rather than EINVAL, as there are independent users for this function Why? We should actually use EEXIST here instead of EINVAL though.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/