On Mon, May 19, 2014 at 07:34:16AM -0700, Christoph Hellwig wrote: > On Mon, May 19, 2014 at 08:31:21AM -0600, Jens Axboe wrote: > > > While you are at it, could you take bio-integrity.c with it? _That_ > > > has zero excuse being anywhere in fs/* - not even "filesystem code > > > uses quite a few functions from that sucker" as with bio.c. > > > FWIW, consider the move ACKed. > > > > Yeah, I did include that in the move. > > Other candidates to move to block/ might be ioprio.c and no-block.c
ACK on ioprio.c (BTW, looking at block... WTF is the story with that pile of blk-* in there? IOW, why blk-exec.c is better than exec.c, etc.?) As for fs/no-block.c... IMO that's a bad idea - it makes sense only if we take fs/block.c there as well, and that one wants fs/internal.h. Why do we need that ->llseek = noop_llseek there, while we are at it? Its ->open() always fails, so how is ->llseek() going to get looked at, let alone called? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
