On Mon, 2014-05-19 at 16:09 -0700, Andrew Morton wrote: > On Fri, 16 May 2014 22:38:15 +0200 Fabian Frederick <f...@skynet.be> wrote: > > Replace while blocksize;shift by fls -1 [] > fls() always makes my brain hurt. ilog() is nicer?
Maybe take an aspirin? ilog2(n) is effectively fls(n) - 1 but n can be either u64 or u64 and ilog2 is compile-time optimized when n is constant. blocksize is a non-const u32 here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/