On Tuesday, May 20, 2014 08:08:11 AM Viresh Kumar wrote: > On 20 May 2014 02:43, Rafael J. Wysocki <r...@rjwysocki.net> wrote: > > What about > > > > if (error) > > return error; > > > > and then you'd save an indentation level? > > Yes. > > > Anyway, I find adding of_node* stuff directly to the driver core this way > > kind of disgusting as there still are platforms that don't use it. > > > > Can we have a call to a function that will change into an empty stub on such > > platforms here, please? > > Okay. But can you explain a bit more about how and where those stubs > would be implemented?
In a header file included by cpu.c. Something like #if defined(CONFIG_OF) && defined(CONFIG_PM_OPP) <function header> #else static inline <stub> #endif -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
