On 05/22/2014 05:43 PM, Linus Torvalds wrote:
Miklos,

this is from your commit 18e480aa07f78 ("parisc: add renameat2
syscall") which was acked by Helge Deller:

On Thu, May 22, 2014 at 10:20 AM, Guenter Roeck <li...@roeck-us.net> wrote:

Unfortunately it appears that the parisc changes cause build failures
with parisc 64 bit builds.

Building parisc:a500_defconfig ... failed
Building parisc:generic-64bit_defconfig ... failed

Error log:
arch/parisc/kernel/built-in.o: In function `sys_call_table':
(.rodata+0xad0): undefined reference to `compat_sys_renameat2'
make: *** [vmlinux] Error 1

only s390 seems to need a compat wrapper, and s390 is kind of odd in
many respects, so I suspect renameat2 should just use ENTRY_SAME() on
parisc, but without any way to *test* it I won't apply the patch.

Guenter, I assume that changing the

         ENTRY_COMP(renameat2)

line in arch/parisc/kernel/syscall_table.S to use ENTRY_SAME() at
least fixes the compile error?


Yes, it fixes the build error for parisc64, and parisc (32 bit) still builds.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to