On Fri, May 23, 2014 at 10:34:55AM +0200, Vlastimil Babka wrote: > From: Vlastimil Babka <[email protected]> > Date: Fri, 23 May 2014 10:18:56 +0200 > Subject: > mm-compaction-properly-signal-and-act-upon-lock-and-need_sched-contention-fix2 > > Step 1: Change function name and comment between v1 and v2 so that the return > value signals the opposite thing. > Step 2: Change the call sites to reflect the opposite return value. > Step 3: ??? > Step 4: Make a complete fool of yourself. > > Signed-off-by: Vlastimil Babka <[email protected]>
Tested-by: Shawn Guo <[email protected]> > --- > mm/compaction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index a525cd4..5175019 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -237,13 +237,13 @@ static inline bool compact_should_abort(struct > compact_control *cc) > if (need_resched()) { > if (cc->mode == MIGRATE_ASYNC) { > cc->contended = true; > - return false; > + return true; > } > > cond_resched(); > } > > - return true; > + return false; > } > > /* Returns true if the page is within a block suitable for migration to */ > -- > 1.8.4.5 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
