On Tue, May 27, 2014 at 08:48:58AM +0800, Zhu, Lejun wrote: > On 5/26/2014 10:51 PM, Mark Brown wrote:
> >> We created these names to hide the implementation of how read/write is > >> done from other platform specific patches interacting with this driver. > >> So when we change the implementation, e.g. from I2C read/write to > >> regmap, we don't have to touch all these patches. > > This sort of HAL is frowned upon in the upstream kernel. > We want to do what other MFD drivers' been doing, and make it easier for > the callers. A couple of similar examples are intel_msic_reg_read() and > lp3943_read_byte(). We want to do the same with intel_soc_pmic_readb(), > and I don't think it's too odd. The odd and problematic bit is the global variable part of things - these wrappers are usually just doing lookup of the underlying I/O handle in the struct for the device and can be implemented as static inlines in the header.
signature.asc
Description: Digital signature
