On Tue, May 27, 2014 at 04:25:54PM +0200, Fabian Frederick wrote: > On Sat, 24 May 2014 20:40:43 -0700 > Josh Triplett <j...@joshtriplett.org> wrote: > > > On Sun, May 25, 2014 at 05:18:36AM +0200, Fabian Frederick wrote: > > > On Sat, 24 May 2014 14:53:22 -0700 > > > Josh Triplett <j...@joshtriplett.org> wrote: > > > > > > > On Sat, May 24, 2014 at 03:06:08PM +0200, Fabian Frederick wrote: > > > > > Convert all except KERN_DEBUG > > > > > > > > Why not KERN_DEBUG? > > > printk(KERN_DEBUG can't be converted to pr_debug the same way as other > > > printk. > > > > True, but I don't see any obvious reason why that prevents you from > > converting them. More importantly, though, you should explain for the > > benefit of the changelog. > > There's no documentation yet in mainline for this but in linux-next: > commit 8ce2658fc31bb7 > > I can submit one more patch with pr_debug conversion using #define DEBUG > or compilation -DDEBUG
Definitely keep it as a separate patch, but I don't think you should define DEBUG by default; just let people turn it on if desired, and leave it out otherwise. There's only a single KERN_DEBUG printk in this driver, and it seems fine to just convert to pr_debug so it gets left out of normal builds. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
