On Tue, 27 May 2014 22:23:51 +0200 Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se> wrote:
> Removal of null pointer checks that could never happen How do you know it never happens? > --- a/fs/ocfs2/move_extents.c > +++ b/fs/ocfs2/move_extents.c > @@ -904,9 +904,6 @@ static int ocfs2_move_extents(struct > ocfs2_move_extents_context *context) > struct buffer_head *di_bh = NULL; > struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); > > - if (!inode) > - return -ENOENT; > - If it's due to assuming that the previous statement would have oopsed then that is mistaken. Is is sometimes the case that gcc will move the evaluation of inode->i_sb to after the test, so this function can be passed NULL and it will not oops. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
