On Thu, 29 May 2014 15:59:00 +0200, Jiri Olsa wrote: > On Thu, May 29, 2014 at 12:58:03PM +0900, Namhyung Kim wrote: >> Hello, >> >> This is a new attempt to implement cumulative hist period report. >> This work begins from Arun's SORT_INCLUSIVE patch [1] but I completely >> rewrote it from scratch. >> >> This patchset basically adds period in a sample to every node in the >> callchain. A hist_entry now has an additional fields to keep the >> cumulative period if --children option is given on perf report. >> >> I changed the option as a separate --children and added a new >> "Children" column (and renamed the default "Overhead" column into >> "Self"). The output will be sorted by children (cumulative) overhead >> for now. It also adds 'overhead_children' field to -F/--fields option >> to be selected by user and it'll show you "N/A" if the cumulation is >> not supported (due to missing callchain). >> >> I added Tested-by from Rodrigo Campos since this version is basically >> rebase of previous series + bugfix. But it still needs to be tested >> more intensively IMHO. Also note that, this will change default >> behavior of perf report/top if callchain is recorded, so might confuse >> old users. Let's see how many of them come to shout. :) I think we >> need to merge Jiri's TUI column header patch at least. >> >> >> * changes in v11: >> - factor out hists__inc_nr_samples (Jiri) >> - remove unrelated change (Jiri) >> - disable accumulation on branch or mem mode >> - slightly refactor hist_iter code > > apart from that comment I sent, I think it's ready to go in
Thanks! As I said, I've pushed v12 to korg with change you commented. And I also found that the overhead in perf_hpp__should_skip() is strangely high.. will check your patch. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
