Re: [PATCH 5/7 v6] trace, RAS: Add eMCA trace event interface

[Chen, Gong]

On Fri, Jun 06, 2014 at 11:21:27AM -0400, Steven Rostedt wrote:
> Date: Fri, 6 Jun 2014 11:21:27 -0400
> From: Steven Rostedt <rost...@goodmis.org>
> To: "Chen, Gong" <gong.c...@linux.intel.com>
> Cc: "Luck, Tony" <tony.l...@intel.com>, Borislav Petkov <b...@alien8.de>,
>  "m.che...@samsung.com" <m.che...@samsung.com>,
>  "linux-a...@vger.kernel.org" <linux-a...@vger.kernel.org>, LKML
>  <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH 5/7 v6] trace, RAS: Add eMCA trace event interface
> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
> 
> On Fri, 6 Jun 2014 02:51:41 -0400
> "Chen, Gong" <gong.c...@linux.intel.com> wrote:
> 
> 
> > +/*
> > + * MCE Extended Error Log trace event
> > + *
> > + * These events are generated when hardware detects a corrected or
> > + * uncorrected event.
> > + */
> > +
> > +/* memory trace event */
> > +
> > +TRACE_EVENT(extlog_mem_event,
> > +   TP_PROTO(struct cper_sec_mem_err *mem,
> > +            u32 err_seq,
> > +            const uuid_le *fru_id,
> > +            const char *fru_text,
> > +            u8 sev),
> > +
> > +   TP_ARGS(mem, err_seq, fru_id, fru_text, sev),
> > +
> > +   TP_STRUCT__entry(
> > +           __field(u32, err_seq)
> > +           __field(u8, etype)
> > +           __field(u8, sev)
> > +           __field(u64, pa)
> > +           __field(u8, pa_mask_lsb)
> > +           __dynamic_array(char, fru, 48)
> > +           __dynamic_array(u8, data, sizeof(struct cper_mem_err_compact))
> 
> For constant size arrays, don't use __dynamic_array() just use
> __array().
> 
Thanks a lot! I will update it.

BTW, any comments from other guys? Boris, Tony? If not, I will send out the
new version tomorrow.

signature.asc
Description: Digital signature