Hi Steve, On Fri, 06 Jun 2014 12:30:37 -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" <rost...@goodmis.org> > > When calculating the average and standard deviation, it is required that > the count be less than UINT_MAX, otherwise the do_div() will get > undefined results. After 2^32 counts of data, the average and standard > deviation should pretty much be set anyway.
[SNIP] > if (bm_cnt > 1) { > /* > * Apply Welford's method to calculate standard deviation: > * s^2 = 1 / (n * (n-1)) * (n * \Sum (x_i)^2 - (\Sum x_i)^2) > */ > stddev = (u64)bm_cnt * bm_totalsq - bm_total * bm_total; > - do_div(stddev, bm_cnt); > - do_div(stddev, bm_cnt - 1); > + do_div(stddev, (u32)bm_cnt); > + do_div(stddev, (u32)bm_cnt - 1); > } else > stddev = 0; I also think that this if-else can go as it checks bm_cnt == 1 above. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/