On Tue, 2014-06-10 at 21:41 +0530, Himangi Saraogi wrote: > Use kstrdup when the goal of an allocation is copy a string into the > allocated region. > > The Coccinelle semantic patch that makes this change is as follows: > > // <smpl> > @@ > expression from,to; > expression flag,E1,E2; > statement S; > @@ > > - to = kmalloc(strlen(from) + 1,flag); > + to = kstrdup(from, flag); > ... when != \(from = E1 \| to = E1 \) > if (to==NULL || ...) S > ... when != \(from = E2 \| to = E2 \) > - strcpy(to, from); > // </smpl> > > Signed-off-by: Himangi Saraogi <[email protected]> > --- > To send to: [email protected] > drivers/message/i2o/memory.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)
I no longer have any I2O hardware so I'm unable to test this. Looks right but does anyone actually still use these drivers ???? Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
