[PATCH v2 1/2] Loosen seams to allow support of other keyboards

[Jamie Lentin]

Signed-off-by: Jamie Lentin <j...@lentin.co.uk>
---
 drivers/hid/hid-lenovo-tpkbd.c | 33 ++++++++++++++++++++++++---------
 1 file changed, 24 insertions(+), 9 deletions(-)

diff --git a/drivers/hid/hid-lenovo-tpkbd.c b/drivers/hid/hid-lenovo-tpkbd.c
index 2d25b6c..3bec9f5 100644
--- a/drivers/hid/hid-lenovo-tpkbd.c
+++ b/drivers/hid/hid-lenovo-tpkbd.c
@@ -1,5 +1,6 @@
 /*
- *  HID driver for Lenovo ThinkPad USB Keyboard with TrackPoint
+ *  HID driver for Lenovo:-
+ *  * ThinkPad USB Keyboard with TrackPoint
  *
  *  Copyright (c) 2012 Bernhard Seibold
  */
@@ -35,7 +36,7 @@ struct tpkbd_data_pointer {
 
 #define map_key_clear(c) hid_map_usage_clear(hi, usage, bit, max, EV_KEY, (c))
 
-static int tpkbd_input_mapping(struct hid_device *hdev,
+static int tpkbd_input_mapping_tp(struct hid_device *hdev,
                struct hid_input *hi, struct hid_field *field,
                struct hid_usage *usage, unsigned long **bit, int *max)
 {
@@ -48,6 +49,15 @@ static int tpkbd_input_mapping(struct hid_device *hdev,
        return 0;
 }
 
+static int tpkbd_input_mapping(struct hid_device *hdev,
+               struct hid_input *hi, struct hid_field *field,
+               struct hid_usage *usage, unsigned long **bit, int *max)
+{
+       if (hdev->product == USB_DEVICE_ID_LENOVO_TPKBD)
+               return tpkbd_input_mapping_tp(hdev, hi, field, usage, bit, max);
+       return 0;
+}
+
 #undef map_key_clear
 
 static int tpkbd_features_set(struct hid_device *hdev)
@@ -338,6 +348,11 @@ static int tpkbd_probe_tp(struct hid_device *hdev)
        char *name_mute, *name_micmute;
        int i;
 
+       /* Ignore unless tpkbd_input_mapping_tp marked it as a pointer */
+       if (!hid_get_drvdata(hdev))
+               return 0;
+       hid_set_drvdata(hdev, NULL);
+
        /* Validate required reports. */
        for (i = 0; i < 4; i++) {
                if (!hid_validate_values(hdev, HID_FEATURE_REPORT, 4, i, 1))
@@ -408,12 +423,9 @@ static int tpkbd_probe(struct hid_device *hdev,
                goto err;
        }
 
-       if (hid_get_drvdata(hdev)) {
-               hid_set_drvdata(hdev, NULL);
-               ret = tpkbd_probe_tp(hdev);
-               if (ret)
-                       goto err_hid;
-       }
+       if (hdev->product == USB_DEVICE_ID_LENOVO_TPKBD
+                       && tpkbd_probe_tp(hdev))
+               goto err_hid;
 
        return 0;
 err_hid:
@@ -437,7 +449,10 @@ static void tpkbd_remove_tp(struct hid_device *hdev)
 
 static void tpkbd_remove(struct hid_device *hdev)
 {
-       if (hid_get_drvdata(hdev))
+       if (!hid_get_drvdata(hdev))
+               return;
+
+       if (hdev->product == USB_DEVICE_ID_LENOVO_TPKBD)
                tpkbd_remove_tp(hdev);
 
        hid_hw_stop(hdev);
-- 
2.0.0.rc2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/