On Wed, Jun 11, 2014 at 10:51 AM, Scot Doyle <lkm...@scotdoyle.com> wrote: > The chromeos_laptop module probes the first i2c adapter with a specific name > for expected hardware. However, the Acer C720 Chromebook has two i2c > adapters with the same name. This patch probes each i2c adapter with a > specific name until locating the expected hardware. > > Thanks to Mika Westerberg for formatting tips and identifying the need for > unique bus addresses within each set of identically-named adapters.
Scot, Is your intention with this patch to replace the one that Mika wrote that specifically special cased the designware i2c busses? He already solved this problem in this patch. https://patchwork.kernel.org/patch/4288591/ I'm not sure about your approach here. It looks like if there's some ambiguity in the names of the busses, you try to probe the device on every bus with that name. We know that bus 0 is going to have the touchpad, and we know that bus 1 is going to have the touchscreen and light sensor. I'd prefer not to send extra probes for all of the combination of devices that don't exist. -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
