On Tue, Jun 17, 2014 at 10:56:04PM +0800, Jeff Liu wrote:
>
> On 06/17/2014 22:42 PM, James Bottomley wrote:
> > On Tue, 2014-06-17 at 22:25 +0800, Jeff Liu wrote:
> >> From: Jie Liu <jeff....@oracle.com>
> >>
> >> It's better to return the actual error rather than NULL because
> >> kset_register() can failed due to other reasons.
> >>
> >> Cc: Christoph Lameter <c...@linux-foundation.org>
> >> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> >> Cc: Andrew Morton <a...@linux-foundation.org>
> >> Cc: Pekka Enberg <penb...@kernel.org>
> >> Cc: Matt Mackall <m...@selenic.com>
> >> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org>
> >> Cc: Paul Mackerras <pau...@samba.org>
> >> Cc: Martin Schwidefsky <schwidef...@de.ibm.com>
> >> Cc: Heiko Carstens <heiko.carst...@de.ibm.com>
> >> Cc: Herbert Xu <herb...@gondor.apana.org.au>
> >> Cc: David S. Miller <da...@davemloft.net>
> >> Cc: Stefan Richter <stef...@s5r6.in-berlin.de>
> >> Cc: Joerg Roedel <j...@8bytes.org>
> >> Cc: James E.J. Bottomley <jbottom...@parallels.com>
> >> Cc: Helge Deller <del...@gmx.de>
> >> Cc: Bjorn Helgaas <bhelg...@google.com>
> >> Cc: Chris Mason <c...@fb.com>
> >> Cc: Josef Bacik <jba...@fb.com>
> >> Cc: Steven Whitehouse <swhit...@redhat.com>
> >> Cc: Boaz Harrosh <bharr...@panasas.com>
> >> Cc: Benny Halevy <bhal...@primarydata.com>
> >> Cc: Christine Caulfield <ccaul...@redhat.com>
> >> Cc: David Teigland <teigl...@redhat.com>
> >> Cc: Theodore Ts'o <ty...@mit.edu>
> >> Cc: Andreas Dilger <adilger.ker...@dilger.ca>
> >> Cc: Jaegeuk Kim <jaeg...@kernel.org>
> >> Cc: Changman Lee <cm224....@samsung.com>
> >> Cc: Mark Fasheh <mfas...@suse.com>
> >> Cc: Joel Becker <jl...@evilplan.org>
> >> Cc: Casey Schaufler <ca...@schaufler-ca.com>
> >> Signed-off-by: Jie Liu <jeff....@oracle.com>
> >> ---
> >> lib/kobject.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/lib/kobject.c b/lib/kobject.c
> >> index 58751bb..538c617 100644
> >> --- a/lib/kobject.c
> >> +++ b/lib/kobject.c
> >> @@ -919,11 +919,11 @@ struct kset *kset_create_and_add(const char *name,
> >>
> >> kset = kset_create(name, uevent_ops, parent_kobj);
> >> if (!kset)
> >> - return NULL;
> >> + return ERR_PTR(-ENOMEM);
> >> error = kset_register(kset);
> >> if (error) {
> >> kfree(kset);
> >> - return NULL;
> >> + return ERR_PTR(error);
> >> }
> >> return kset;
> >> }
> >
> > This patch series isn't bisectable. When changing an error signal from
> > NULL to non-NULL, you have to do it as one patch, otherwise if a
> > bisection lands in here we'll get error returns from all our kobject
> > kset code and the kernel won't boot.
>
> Thanks for pointing this out.
>
> > It's fine if you're sending it out as 24 patches for review, but it has
> > to be applied as a single one.
>
> Ok, I'll post the v2 patch as a single one once this series has been reviewed.
Also, now that you sent a bunch of different patches out, some
maintainers will not realize that this first one has to be applied (i.e.
you gave them no sense that there was a dependancy.)
You will have to watch very carefully to ensure that those patches do
not now get accepted, as they will break the existing code.
Not good.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
