On 06/17/2014 23:50 PM, Greg KH wrote: > On Tue, Jun 17, 2014 at 10:56:04PM +0800, Jeff Liu wrote: >> >> On 06/17/2014 22:42 PM, James Bottomley wrote: >>> On Tue, 2014-06-17 at 22:25 +0800, Jeff Liu wrote: >>>> From: Jie Liu <jeff....@oracle.com> >>>> >>>> It's better to return the actual error rather than NULL because >>>> kset_register() can failed due to other reasons. >>>>
<snip> >>>> >>> >>> This patch series isn't bisectable. When changing an error signal from >>> NULL to non-NULL, you have to do it as one patch, otherwise if a >>> bisection lands in here we'll get error returns from all our kobject >>> kset code and the kernel won't boot. >> >> Thanks for pointing this out. >> >>> It's fine if you're sending it out as 24 patches for review, but it has >>> to be applied as a single one. >> >> Ok, I'll post the v2 patch as a single one once this series has been >> reviewed. > > Also, now that you sent a bunch of different patches out, some > maintainers will not realize that this first one has to be applied (i.e. > you gave them no sense that there was a dependancy.) > > You will have to watch very carefully to ensure that those patches do > not now get accepted, as they will break the existing code. Ok, and I'll inform every other maintainers do not apply their patch individually. Cheers, -Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
