Hi It's a bit confusing with this, I have received a lot of complaints that I have not had a cover letter. When should I include it? In an obvious patching. But where there's a need to explain anything further should have a cover letter.
In this case, I suspected that there is a missed special case, that I mentioned in the cover letter. But did my patch that otherwise took away the otherwise unnecessary code. Thought it was the right use...? Kind regards Rickard Strandqvist 2014-06-16 11:05 GMT+02:00 Dan Carpenter <[email protected]>: > On Sun, Jun 15, 2014 at 07:20:57PM +0200, Rickard Strandqvist wrote: >> The same code regardless of the outcome of the if statement. This may of >> course be a miss and there should be a difference in the code. >> And clean up another duplicate line of code. >> >> This was partly found using a static code analysis program called cppcheck. >> > > We don't need a cover letter for a single patch. Just put this stuff in > the patch description next time. > > regards, > dan carpenter > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
