On Mon, Jun 23, 2014 at 02:23:24PM -0400, Greg KH wrote: > On Mon, Jun 23, 2014 at 08:16:48PM +0300, Janne Kanniainen wrote: > > + ret = sysfs_create_group(&led->hdev->dev.kobj, >683r_attribute_group); > > + if (ret) { > > + hid_err(hdev, "failed to create sysfs attributes\n"); > > + goto fail; > > + } > > No, you need to set the attribute group _before_ you call > led_classdev_register, as that is where the device will be created in > sysfs. Surely the other led drivers already do this? I'm almost afraid > to go look...
Yes, they do it already, set .dev_attr_group and you should be fine. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/