Hi Boris,

On 06/25/2014 03:30 PM, Boris BREZILLON wrote:
Hello Bo,

On 25/06/2014 08:59, Bo Shen wrote:
Hi Boris,

On 06/25/2014 06:44 AM, Boris BREZILLON wrote:
Add ethernet-phy node to specify phy address (on the MDIO bus) and phy
interrupt (connected to pin PB25).

Define board specific delays to apply to RGMII signals.

Signed-off-by: Boris BREZILLON <[email protected]>
---
   arch/arm/boot/dts/sama5d3xcm.dtsi | 16 ++++++++++++++++
   1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/sama5d3xcm.dtsi
b/arch/arm/boot/dts/sama5d3xcm.dtsi
index b0b1331..2185ad8 100644
--- a/arch/arm/boot/dts/sama5d3xcm.dtsi
+++ b/arch/arm/boot/dts/sama5d3xcm.dtsi
@@ -34,6 +34,22 @@

               macb0: ethernet@f0028000 {
                   phy-mode = "rgmii";
+                #address-cells = <1>;
+                #size-cells = <0>;
+
+                ethernet-phy@1 {

The GMAC PHY address is 0x7 while not 0x1.

Are you sure of that ? I checked sama5d3x-ek schematics.

On sama5d3x-ek schematic, it is EMAC PHY (ksz8051RNL, it's address is 0x1), while not GMAC PHY. You should check the sama5d3x-CM schematic.

On these schematics PHYAD0 is connected to a pull up resistor and
PHYAD1/2 are connected to a pull down one.
This gives PHYAD[4:0] = 0b00001 = 0x1.
Is there some bootloader mechanisms that changes PHYAD[0-2] pin status
and reset the PHY ?


+                    interrupt-parent = <&pioB>;
+                    interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
+                    reg = <1>;

Nitpick: as usual, we will add "0x" prefix in reg property.

Sure, I'll fix that.


+                    txen-skew-ps = <800>;
+                    txc-skew-ps = <12000>;

Should be 3000 (0xf * 200 ps) not 12000.

+                    rxdv-skew-ps = <400>;
+                    rxc-skew-ps = <12000>;

Ditto.

Best Regards,

Boris

Best Regards,
Bo Shen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to