This patch does away with cast on void * and the if as it is unnecessary. The following Coccinelle semantic patch was used for making the change:
@r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by: Himangi Saraogi <himangi...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> --- fs/kernfs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c index 1c77193..85738f4 100644 --- a/fs/kernfs/dir.c +++ b/fs/kernfs/dir.c @@ -188,7 +188,7 @@ static unsigned int kernfs_name_hash(const char *name, const void *ns) unsigned int len = strlen(name); while (len--) hash = partial_name_hash(*name++, hash); - hash = (end_name_hash(hash) ^ hash_ptr((void *)ns, 31)); + hash = (end_name_hash(hash) ^ hash_ptr(ns, 31)); hash &= 0x7fffffffU; /* Reserve hash numbers 0, 1 and INT_MAX for magic directory entries */ if (hash < 2) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/