Hi Martin, On 06/30/2014 07:15 AM, Martin K. Petersen wrote: >>>>>> "Gu" == Gu Zheng <guz.f...@cn.fujitsu.com> writes: > > [Sorry about the delay. I'm on vacation right now.] > > Gu> But it seems that bip_integrity_vecs() will return the wrong number > Gu> if the bio is not based on any bio_set for some reason(bio->bi_pool > Gu> == NULL), because in that case, the bip_inline_vecs[0] is malloced > Gu> directly. So here we add the bip_max_vcnt to record the count of > Gu> vector slots, and cleanup the function bip_integrity_vecs(). > > I'm in agreement with your fix.
Thanks. > > However, I'm still not sure what the use case is for bios without an > associated bioset. I do not see any callers that pass in a NULL bioset. Please refer to bio_kmalloc()--alloc bio via kmalloc. And IMO, the API(e.g. bio_alloc_bioset) is EXPORT, any guys(including some out of mainline code, some special drivers) can alloc a bio via kmalloc without based on associated bioset. Regards, Gu > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
