On Tue, Jun 17, 2014 at 1:12 AM, Mathieu Poirier <mathieu.poir...@linaro.org> wrote: > On 3 June 2014 03:09, Linus Walleij <linus.wall...@linaro.org> wrote: >> On Fri, May 30, 2014 at 3:43 PM, <mathieu.poir...@linaro.org> wrote:
>>> + int read_count; >> >> Can this really be negative? > > It is useful for debugging, as an example see "tmc_release()". If the > count drops below '0' there is obviously a problem. Do you see a cost > in keeping this as an 'int'? What do you advise here? No big deal, keep it. >> This struct overall could use some kerneldoc. > > Would writing a comment for each field qualify? Like above the struct, see Documentation/kernel-doc-nano-HOWTO.txt >>> + drvdata->base = devm_ioremap(dev, res->start, resource_size(res)); >> >> Use devm_ioremap_resource() instead. > > I'm working on it. Bet it's fininshed now ;-) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/