On Tue, Jul 08, 2014 at 02:01:04PM -0700, Joe Perches wrote: > On Tue, 2014-07-08 at 13:41 -0700, Paul E. McKenney wrote: > > On Tue, Jul 08, 2014 at 11:06:24AM -0700, Joe Perches wrote: > > > On Tue, 2014-07-08 at 10:09 +0200, Peter Zijlstra wrote: > > > > On Mon, Jul 07, 2014 at 03:42:03PM -0700, Paul E. McKenney wrote: > > > > > MAINTAINERS | 8 ++++++++ > > > > > 1 file changed, 8 insertions(+) > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > > index 1814075c0e74..92f2bf91eec1 100644 > > > > > --- a/MAINTAINERS > > > > > +++ b/MAINTAINERS > > > > > @@ -7405,6 +7405,9 @@ F: kernel/rcu/torture.c > > > > > > > > > > RCUTORTURE TEST FRAMEWORK > > > > > M: "Paul E. McKenney" <paul...@linux.vnet.ibm.com> > > > > > +R: Steven Rostedt <rost...@goodmis.org> > > > > > +R: Mathieu Desnoyers <mathieu.desnoy...@efficios.com> > > > > > +R: Lai Jiangshan <la...@cn.fujitsu.com> > > > > > L: linux-kernel@vger.kernel.org > > > > > S: Supported > > > > > T: git > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > > > > > > > > OK,.. so if we're going to do this can we talk about the syntax here. > > > > > > > > I would like to also use this for SCHED and PERF, but since both are > > > > rather big I would like to be able to subdivide things. Now I could of > > > > course go create many MAINTAINER sections, but that feels artificial. > > > > > > > > So I would like to be able to write: > > > > > > > > SCHEDULER: > > > > ... > > > > R: Steven Rostedt <rost...@goodmis.org> (kernel/sched/rt.c) > > > > R: Juri Lelli <juri.le...@gmail.com> (kernel/sched/deadline.c) > > > > > > > > or something like that. And here I've already done concessions in that > > > > the above is machine readable. Ideally I'd be able to say things like: > > > > 'for sched and numa related things' add 'rik and mel'. > > > > > > > > Hmm, maybe we can look at the patch subject tag like: sched/numa or > > > > sched/rt or sched/deadline etc.. instead of the files touched. > > > > > > I think it's best to use separate sections. > > > > > > The parsing logic in get_maintainers is already ugly enough. > > > > OK, here is a basic change. Hey, I figure that if you weren't desperately > > in need of entertainment, you would not have asked me to hack a perl script! > > > > Thanx, Paul > > > > ------------------------------------------------------------------------ > > > > scripts: Teach get_maintainer.pl about the new "R:" tag
[ . . . ] > Paul, I already sent you a better version over a month ago. That would explain why I had already forgotten about it. ;-) > https://lkml.org/lkml/2014/6/2/585 Unless you tell me otherwise, I assume that this means that you are OK with my adding your Signed-off-by to that patch. (The lack thereof being another reason I would not have queued it.) Please see below for the proposed commit log and Signed-off-by. If you don't tell me otherwise, I will submit this to the next merge window. Thanx, Paul ------------------------------------------------------------------------ scripts: Teach get_maintainer.pl about the new "R:" tag We can now designate reviewers in the MAINTAINERS file with the new "R:" tag, so this commit teaches get_maintainers.pl to add their email addresses. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Paul E. McKenney <paul...@linux.vnet.ibm.com> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 41987885bd31..d7016279ec2b 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -21,6 +21,7 @@ my $lk_path = "./"; my $email = 1; my $email_usename = 1; my $email_maintainer = 1; +my $email_reviewer = 1; my $email_list = 1; my $email_subscriber_list = 0; my $email_git_penguin_chiefs = 0; @@ -202,6 +203,7 @@ if (!GetOptions( 'remove-duplicates!' => \$email_remove_duplicates, 'mailmap!' => \$email_use_mailmap, 'm!' => \$email_maintainer, + 'r!' => \$email_reviewer, 'n!' => \$email_usename, 'l!' => \$email_list, 's!' => \$email_subscriber_list, @@ -260,7 +262,8 @@ if ($sections) { } if ($email && - ($email_maintainer + $email_list + $email_subscriber_list + + ($email_maintainer + $email_reviewer + + $email_list + $email_subscriber_list + $email_git + $email_git_penguin_chiefs + $email_git_blame) == 0) { die "$P: Please select at least 1 email option\n"; } @@ -750,6 +753,7 @@ MAINTAINER field selection options: --hg-since => hg history to use (default: $email_hg_since) --interactive => display a menu (mostly useful if used with the --git option) --m => include maintainer(s) if any + --r => include reviewer(s) if any --n => include name 'Full Name <addr\@domain.tld>' --l => include list(s) if any --s => include subscriber only list(s) if any @@ -1064,6 +1068,22 @@ sub add_categories { my $role = get_maintainer_role($i); push_email_addresses($pvalue, $role); } + } elsif ($ptype eq "R") { + my ($name, $address) = parse_email($pvalue); + if ($name eq "") { + if ($i > 0) { + my $tv = $typevalue[$i - 1]; + if ($tv =~ m/^(\C):\s*(.*)/) { + if ($1 eq "P") { + $name = $2; + $pvalue = format_email($name, $address, $email_usename); + } + } + } + } + if ($email_reviewer) { + push_email_addresses($pvalue, 'reviewer'); + } } elsif ($ptype eq "T") { push(@scm, $pvalue); } elsif ($ptype eq "W") { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
