From: Thierry Reding <[email protected]>

The code uses a the following to zero out a PDA:

        memset(pda, 0, sizeof(pda));

But sizeof(pda) will return the size of a pointer rather than the size
of the structure pointed to. This triggers the following warning from
GCC:

        arch/ia64/sn/kernel/setup.c:582:23: warning: argument to 'sizeof' in 
'memset' call is the same pointer type 'struct pda_s *' as the destination; 
expected 'struct pda_s' or an explicit length [-Wsizeof-pointer-memaccess]
          memset(pda, 0, sizeof(pda));
                               ^

Fix this by passing in the size of the structure using sizeof(*pda)
instead.

Signed-off-by: Thierry Reding <[email protected]>
---
 arch/ia64/sn/kernel/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/ia64/sn/kernel/setup.c b/arch/ia64/sn/kernel/setup.c
index 53b01b8e2f19..36182c84363c 100644
--- a/arch/ia64/sn/kernel/setup.c
+++ b/arch/ia64/sn/kernel/setup.c
@@ -579,7 +579,7 @@ void sn_cpu_init(void)
                       (sn_prom_type == 1) ? "real" : "fake");
        }
 
-       memset(pda, 0, sizeof(pda));
+       memset(pda, 0, sizeof(*pda));
        if (ia64_sn_get_sn_info(0, &sn_hub_info->shub2,
                                &sn_hub_info->nasid_bitmask,
                                &sn_hub_info->nasid_shift,
-- 
2.0.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to