At Tue, 5 Aug 2014 18:19:37 +0200, [email protected] wrote: > > From: Jean-Michel Hautbois <[email protected]> > > This patch corrects a lack of testing. > If fw is NULL when calling firmware_load(), it results in a kernel oops. > > Signed-off-by: Jean-Michel Hautbois <[email protected]>
Reviewed-by: Takashi Iwai <[email protected]> Takashi > --- > drivers/misc/lattice-ecp3-config.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/misc/lattice-ecp3-config.c > b/drivers/misc/lattice-ecp3-config.c > index 7ffdb58..7e1efd5 100644 > --- a/drivers/misc/lattice-ecp3-config.c > +++ b/drivers/misc/lattice-ecp3-config.c > @@ -79,6 +79,11 @@ static void firmware_load(const struct firmware *fw, void > *context) > u32 jedec_id; > u32 status; > > + if (fw == NULL) { > + dev_err(&spi->dev, "Cannot load firmware, aborting\n"); > + return; > + } > + > if (fw->size == 0) { > dev_err(&spi->dev, "Error: Firmware size is 0!\n"); > return; > -- > 2.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
