Quoting Konstantin Khlebnikov ([email protected]): > Security operation ->inode_listsecurity is used for generating list of > available extended attributes for syscall listxattr. Currently it's used > only in nfs4 or if filesystem doesn't provide i_op->listxattr. > > The list is the set of NULL-terminated names, one after the other. > This method must include zero byte at the and into result. > > Also this function must return length even if string does not fit into > output buffer or it is NULL, see similar method in selinux and man listxattr. > > Signed-off-by: Konstantin Khlebnikov <[email protected]>
Acked-by: Serge Hallyn <[email protected]> > --- > security/smack/smack_lsm.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c > index e6ab307..b11ab23 100644 > --- a/security/smack/smack_lsm.c > +++ b/security/smack/smack_lsm.c > @@ -1122,13 +1122,12 @@ static int smack_inode_getsecurity(const struct inode > *inode, > static int smack_inode_listsecurity(struct inode *inode, char *buffer, > size_t buffer_size) > { > - int len = strlen(XATTR_NAME_SMACK); > + int len = sizeof(XATTR_NAME_SMACK); > > - if (buffer != NULL && len <= buffer_size) { > + if (buffer != NULL && len <= buffer_size) > memcpy(buffer, XATTR_NAME_SMACK, len); > - return len; > - } > - return -EINVAL; > + > + return len; > } > > /** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
