On Wed, Aug 13, 2014 at 10:11:59AM +0100, Lee Jones wrote: > Hi Brian, Pekon, > > I believe all of your queries have either been answered or addressed > and I am hoping this will be the last submission. :) > > /me crosses fingers! > > Kind regards, > Lee
I didn't look through the patches yet, but my build tools tell me you didn't compile-test this. Please compile, test, and resend your patches. In file included from drivers/mtd/nand/stm_nand_bch.c:26:0: include/linux/mtd/stm_nand_bbt.h:16:13: warning: no previous prototype for 'nandi_dump_bad_blocks' [-Wmissing-prototypes] drivers/mtd/nand/stm_nand_bch.c: In function 'nandi_set_mtd_defaults': drivers/mtd/nand/stm_nand_bch.c:870:19: error: 'bch_scan_bbt' undeclared (first use in this function) drivers/mtd/nand/stm_nand_bch.c:870:19: note: each undeclared identifier is reported only once for each function it appears in drivers/mtd/nand/stm_nand_bch.c:871:20: error: 'bch_block_isbad' undeclared (first use in this function) drivers/mtd/nand/stm_nand_bch.c:872:24: error: 'bch_block_markbad' undeclared (first use in this function) drivers/mtd/nand/stm_nand_bch.c: In function 'bch_calc_timing_registers': drivers/mtd/nand/stm_nand_bch.c:1022:6: warning: variable 'ren_half_off' set but not used [-Wunused-but-set-variable] drivers/mtd/nand/stm_nand_bch.c:1021:6: warning: variable 'ren_half_on' set but not used [-Wunused-but-set-variable] Particularly, take a hard look at rewriting include/linux/mtd/stm_nand_bbt.h. Thanks, Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
