FYI only if you missed my previous 2 replies which didn't reach the mailing list. Thanks.
On Mon, Aug 18, 2014 at 12:13 PM, Sahara <[email protected]> wrote: > > 2014년 08월 16일 03:34, Rusty Russell 쓴 글: > >> [email protected] writes: >>> >>> From: Sahara <[email protected]> >>> >>> Although there are many obs_kernel_param and its names are >>> earlyprintk and also EARLY_PRINTK is also enabled, we could not >>> see the early_printk output properly until now. This patch >>> considers earlycon as well as earlyprintk. >> >> Hmm, the initial "earlycon" hack slipped in when I wasn't looking. >> I don't think we should extend it. >> >> Why not make the thing(s) you want early_param()s? >> >> Cheers, >> Rusty. > > The earlycon and the earlyprintk are scattered and used in many > architectures. > It looks earlycon just could be a subset of earlyprintk. > The earlycon is for uart specific, while the earlyprintk is to support vga, > efi, xen, serial, and so on. Especially ARM uses earlyprintk in many places. > And, I am not sure if this is a good chance to replace all the earlyprintk > with the earlycon. As of now, it's fair for both earlycon and earlyprintk. > Or perhaps removing case#2, see in my previous email to Andrew Morton, is > better?, so users be forced to specify earlycon and earlyprintk in cmdline > if they want to see early_printk() output. > > Thanks. > > Best Regards, > Sahara. > > >> >>> --- a/init/main.c >>> +++ b/init/main.c >>> @@ -426,7 +426,8 @@ static int __init do_early_param(char *param, char >>> *val, const char *unused) >>> for (p = __setup_start; p < __setup_end; p++) { >>> if ((p->early && parameq(param, p->str)) || >>> (strcmp(param, "console") == 0 && >>> - strcmp(p->str, "earlycon") == 0) >>> + ((strcmp(p->str, "earlycon") == 0) || >>> + (strcmp(p->str, "earlyprintk") == 0))) >>> ) { >>> if (p->setup_func(val) != 0) >>> pr_warn("Malformed early option '%s'\n", >>> param); >>> -- >>> 1.7.9.5 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
