On Sat, Aug 16, 2014 at 10:29:16PM +0200, Manfred Spraul wrote: > Hi Andrew, > > On 08/14/2014 03:34 PM, Andrew Vagin wrote: > >On Thu, Aug 14, 2014 at 11:37:45AM +0200, Manfred Spraul wrote: > >>Hi Andrey, > >> > >>[...] > >>What do you use auto_msgmni for? > >We disable it to check that criu restores a value of the msgmni sysctl > >correctly. > > > >https://github.com/xemul/criu/blob/master/test/zdtm/live/static/ipc_namespace.c > Thanks for the link, if I see it right, my patch would break your code: > > http://marc.info/?l=linux-kernel&m=140782863804950 > > It removes auto_msgmni - and > What do you think, should I leave auto_msgmni as a stale variable, perhaps > with a pr_info() that it doesn't have any effect?
Yes, you should. For example "criu restore" will start failing, if you remove auto_msgmni. > > > -- > Manfred -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
