On Saturday, August 23, 2014 at 02:13:55 AM, Robin Gong wrote: > After enable DMA
Please also add a commit message which describes the change, not only some test results. [...] > @@ -911,6 +1194,13 @@ static int spi_imx_probe(struct platform_device > *pdev) goto out_put_per; > > spi_imx->spi_clk = clk_get_rate(spi_imx->clk_per); > + /* > + * Only validated on i.mx6 now, can remove the constrain if validated on > + * other chips. > + */ Given that the check below tests for imx51_ecspi_devtype_data ... does that mean, that this code was never tested on MX51 and MX53, yet will be enabled for those chips and might possibly break them ? > + if (spi_imx->devtype_data == &imx51_ecspi_devtype_data > + && spi_imx_sdma_init(&pdev->dev, spi_imx, master, res)) > + dev_err(&pdev->dev, "dma setup error,use pio instead\n"); > > spi_imx->devtype_data->reset(spi_imx); > > @@ -949,6 +1239,7 @@ static int spi_imx_remove(struct platform_device > *pdev) writel(0, spi_imx->base + MXC_CSPICTRL); > clk_unprepare(spi_imx->clk_ipg); > clk_unprepare(spi_imx->clk_per); > + spi_imx_sdma_exit(spi_imx); > spi_master_put(master); > > return 0; Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
