On 08/25/2014 07:07 PM, Eduardo Valentin wrote: > Hello Wei Ni, > > On Mon, Aug 25, 2014 at 02:29:47PM +0800, Wei Ni wrote: >> Add more description for the "polling-delay" property. >> Set "trips" and "cooling maps" as optional property, because >> if missing these two sub-nodes, the thermal zone device still >> work properly. >> >> Signed-off-by: Wei Ni <w...@nvidia.com> >> --- >> Documentation/devicetree/bindings/thermal/thermal.txt | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt >> b/Documentation/devicetree/bindings/thermal/thermal.txt >> index f5db6b7..e3d3ed9 100644 >> --- a/Documentation/devicetree/bindings/thermal/thermal.txt >> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt >> @@ -136,8 +136,8 @@ containing trip nodes and one sub-node containing all >> the zone cooling maps. >> >> Required properties: >> - polling-delay: The maximum number of milliseconds to wait between polls >> - Type: unsigned when checking this thermal zone. >> - Size: one cell >> + Type: unsigned when checking this thermal zone. If this value is 0, the >> + Size: one cell driver will not run polling queue, but just cancel it. >> > > The description above is specific to Linux kernel implementation > nomenclature. DT description needs to be OS agnostic.
Normally, the user may think a delay of 0 means that software continually polls this zone, but in here it mean no polling. May be it's better to add this description. > >> - polling-delay-passive: The maximum number of milliseconds to wait >> Type: unsigned between polls when performing passive cooling. >> @@ -148,14 +148,16 @@ Required properties: >> phandles + sensor >> specifier >> >> +Optional property: >> - trips: A sub-node which is a container of only trip point nodes >> Type: sub-node required to describe the thermal zone. >> >> - cooling-maps: A sub-node which is a container of only cooling >> device >> Type: sub-node map nodes, used to describe the relation between trips >> - and cooling devices. >> + and cooling devices. If missing the "trips" property, >> + This sub-node will not be parsed, because no trips can >> + be bound to cooling devices. > > Do you mean if the thermal zone misses the "trips" property? Actually, > the binding describes both, cooling-maps and trips, as required > properties. Thus, both needs to be in place to consider the thermal zone > as a proper described zone. > >> >> -Optional property: >> - coefficients: An array of integers (one signed cell) >> containing >> Type: array coefficients to compose a linear relation >> between >> Elem size: one cell the sensors listed in the thermal-sensors >> property. >> -- >> 1.8.1.5 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
