Hi! > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc1/2.6.12-rc1-mm1/ > > > > I get the following BUG every time I try to suspend my box to disk. > > Pavel, that's the BUG() in pci_choose_state(). I did have some > reject-fixing to do on that wrt a change in Greg's tree, so maybe there was > some incompatible intent in there. > > I dunno why pci_choose_state() is saying that it received PCI_D1, when > prepare_devices() is passing down PMSG_FREEZE?
This works it around: --- clean-mm/drivers/pci/pci.c 2005-03-21 11:39:32.000000000 +0100 +++ linux-mm/drivers/pci/pci.c 2005-03-22 01:41:48.000000000 +0100 @@ -376,11 +376,13 @@ if (!pci_find_capability(dev, PCI_CAP_ID_PM)) return PCI_D0; +#if 0 if (platform_pci_choose_state) { ret = platform_pci_choose_state(dev, state); if (ret >= 0) state = ret; } +#endif switch (state) { case 0: return PCI_D0; case 3: return PCI_D3hot; platform_pci_choose_state is very wrong, and it would be nice to just revert the patch that introduced it. pm_message_t is going to became a structure, and I don't want to have another place to fixup. Hmm, it looks like I should do switch to the structure *now* so that pm_message_t becomes incompatible with int and people can't get it wrong... Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/