On Mon, Sep 1, 2014 at 4:54 PM, Rob Jones <rob.jo...@codethink.co.uk> wrote: > > > On 01/09/14 14:43, Alexey Dobriyan wrote: >>> >>> void *__seq_open_private(struct file *f, const struct seq_operations >>> *ops, >>> - int psize) >>> + size_t psize) >> >> >> It should be "unsigned int" at most. >> As almost all in-kernel lengths.
> I don't agree. Ultimately this parameter ends up as a parameter to > kmalloc where it is expected to be a size_t. Which is a mistake too because allocations are never that large. Save REX prefix, keep length unsigned int! Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/