Yichen Xie <[EMAIL PROTECTED]> wrote: > Is the memory block allocated on line 315 leaked every time tcp_ipt_dump > is called?
It seems to be. This patch should free it. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> BTW, please report networking bugs to [EMAIL PROTECTED] Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- ===== net/sched/ipt.c 1.14 vs edited ===== --- 1.14/net/sched/ipt.c 2005-02-07 16:39:40 +11:00 +++ edited/net/sched/ipt.c 2005-03-23 22:28:13 +11:00 @@ -284,10 +284,12 @@ tm.lastuse = jiffies_to_clock_t(jiffies - p->tm.lastuse); tm.expires = jiffies_to_clock_t(p->tm.expires); RTA_PUT(skb, TCA_IPT_TM, sizeof (tm), &tm); + kfree(t); return skb->len; rtattr_failure: skb_trim(skb, b - skb->data); + kfree(t); return -1; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
