On Monday, September 08, 2014 08:51:31 PM Hanjun Guo wrote: > Hi Gerry, Rafael, > > On 2014年09月08日 06:37, Rafael J. Wysocki wrote: > > On Thursday, August 28, 2014 10:22:29 AM Jiang Liu wrote: > >> Now all code in processor_core.c is APIC ID related, so rename it as > >> apic_id.c. Later IOAPIC ID related code will be added into apic_id.c. > > Actually, I'm not sure about this one. > > > > Renames like this make it difficult to backport things in general > > and kind of break "git blame", so do we have to do that? > > > > What's wrong with leaving the name as is and adding a comment > > about the contents being related to IOAPIC ID? > > It will be thankful for not renaming the file into apic_id.c, because apic id > is x86 specific, > and platform like ARM will also add some code to get cpu hardware id via GICC > structure > in MADT table in that file, apic id is not a generic name for both x86 and > ARM, I prefer to > keep it as it is :)
Well, that's a good argument too. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
