On 14/09/14 11:50, Chen Gang wrote: > Both zero and positive number can indicate success, so the original > comments need be improved. > > Signed-off-by: Chen Gang <gang.chen.5...@gmail.com> > --- > drivers/xen/xenbus/xenbus_client.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/xen/xenbus/xenbus_client.c > b/drivers/xen/xenbus/xenbus_client.c > index 277e74d..e2cf681 100644 > --- a/drivers/xen/xenbus/xenbus_client.c > +++ b/drivers/xen/xenbus/xenbus_client.c > @@ -361,8 +361,8 @@ static void xenbus_switch_fatal(struct xenbus_device > *dev, int depth, int err, > * @ring_mfn: mfn of ring to grant > > * Grant access to the given @ring_mfn to the peer of the given device. > Return > - * 0 on success, or -errno on error. On error, the device will switch to > - * XenbusStateClosing, and the error will be saved in the store. > + * 0 or positive number on success, or -errno on error. On error, the device > + * will switch to XenbusStateClosing, and the error will be saved in the > store.
If you're going to update this comment, please state what it is actually returning: i.e., a grant reference or -ve on error. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
