On Mon, Sep 22, 2014 at 01:45:22PM -0700, Andrew Morton wrote: > On Mon, 22 Sep 2014 09:03:08 +0900 Minchan Kim <[email protected]> wrote: > > > Now, swap leans on !p->highest_bit to indicate a swap is full. > > It works well for normal swap because every slot on swap device > > is used up when the swap is full but in case of zram, swap sees > > still many empty slot although backed device(ie, zram) is full > > since zram's limit is over so that it could make trouble when > > swap use highest_bit to select new slot via free_cluster. > > > > This patch introduces full varaiable in swap_info_struct > > to solve the problem. > > > > ... > > > > --- a/include/linux/swap.h > > +++ b/include/linux/swap.h > > @@ -224,6 +224,7 @@ struct swap_info_struct { > > struct swap_cluster_info free_cluster_tail; /* free cluster list tail */ > > unsigned int lowest_bit; /* index of first free in swap_map */ > > unsigned int highest_bit; /* index of last free in swap_map */ > > + bool full; /* whether swap is full or not */ > > This is protected by swap_info_struct.lock, I worked out. > > There's a large comment at swap_info_struct.lock which could be updated.
Sure. -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
