On Wed, Sep 24, 2014 at 11:12:36AM +0200, Arnd Bergmann wrote: > As a start, we could probably take the proposed device_for_each_child_node > and move that into the leds-core, changing the fw_dev_node argument > for an led_classdev with the addition of the of_node and acpi_object > members. It would still leave it up to the gpio-leds driver to do > > if (led_cdev->of_node) > gpiod = devm_of_get_gpiod(led_cdev->of_node, ...); > else > gpiod = devm_acpi_get_gpiod(led_cdev->acpi_object, ...); > > but there seems little benefit in abstracting this because there is > only one driver that needs it.
The same interface is used also in gpio_keys_polled.c driver so if we want to avoid duplicating code this needs to be abstracted away from the drivers. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
