> > This looks to be a carbon copy of the vexpress pseudo-hotplug in > > arch/arm/mach-vexpress/hotplug.c, which is obviously broken in the way > > you describe above. Perhaps we should go about ripping that out? > > The Versatile Express does not support suspend so the only problem case > is kexec. However, isn't this support needed for big.LITTLE, and as > the Versatile Express is the platform which these features get developed > on, having working CPU hotplug seems rather fundamental for ARM kernel > feature development. > > In that regard, Versatile Express is something of a special case.
It is admittedly helpful during development to perform pseudo-hotplug on Versatile Express. I have a local patch adding vexpress_cpu_disable so I can test for bugs that only trigger if CPU0 is hotplugged. Given that, perhaps we should make it clearer that Versatile Express is not a reference implementation for CPU hotplug; add some Kconfig (e.g. VEXPRESS_PSEUDO_HOTPLUG) that depends on !KEXEC && !SUSPEND, and putting a note in hotplug.c stating it's not suitable as a reference implementation. ...but perhaps that's overkill. Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
