On Tue, Sep 30, 2014 at 04:11:48AM +0100, Bryan O'Donoghue wrote:
> Make an update to identify_cpu to make an explicit call to default_init()
> We want to do this since some processors that report vendor strings via
> cpuid also want to run legacy_cache_size callbacks - which won't happen
> since init_intel() init_amd() and friends take the place of default_init()
> and don't themselves make explicit calls to legacy_cache_size.
>
> Also current code has an
> #ifdef CONFIG_X86_64
> cpu_detect_cache_sizes(c);
> #endif
...
> static void default_init(struct cpuinfo_x86 *c)
> {
> -#ifdef CONFIG_X86_64
> cpu_detect_cache_sizes(c);
> -#else
> +
> /* Not much we can do here... */
> /* Check if at least it has cpuid */
> if (c->cpuid_level == -1) {
> @@ -79,7 +78,6 @@ static void default_init(struct cpuinfo_x86 *c)
> else if (c->x86 == 3)
> strcpy(c->x86_model_id, "386");
> }
> -#endif
Shouldn't this patch be more like..
-#ifdef CONFIG_X86_64
cpu_detect_cache_sizes(c);
-#else
+
+#ifdef CONFIG_X86_32
?
The 386/486 stuff in this codepath isn't huge, but it
seems pointless to be compiling it on 64-bit.
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
