On Tue, 2014-30-09 at 10:34:56 UTC, Michael Neuling wrote: > From: Ian Munsie <imun...@au1.ibm.com> > > This new header add defines for callbacks and structs needed by the rest of > the adds > kernel to hook into the cxl infrastructure. > > Empty functions are provided when CONFIG CXL_BASE is not enabled. > > Signed-off-by: Ian Munsie <imun...@au1.ibm.com> > Signed-off-by: Michael Neuling <mi...@neuling.org> > --- > include/misc/cxl.h | 34 ++++++++++++++++++++++++++++++++++
include/misc is kind of weird. I guess it's a misc device. Any reason not to have it in arch/powerpc/include ? > diff --git a/include/misc/cxl.h b/include/misc/cxl.h > new file mode 100644 > index 0000000..bde46a3 > --- /dev/null > +++ b/include/misc/cxl.h > @@ -0,0 +1,34 @@ > +/* > + * Copyright 2014 IBM Corp. > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by the Free Software Foundation; either version > + * 2 of the License, or (at your option) any later version. > + */ > + > +#ifndef _MISC_ASM_CXL_H No ASM. > +#define _MISC_ASM_CXL_H > + > +#define CXL_IRQ_RANGES 4 > + > +struct cxl_irq_ranges { > + irq_hw_number_t offset[CXL_IRQ_RANGES]; > + irq_hw_number_t range[CXL_IRQ_RANGES]; > +}; > + > +#ifdef CONFIG_CXL_BASE > + > +void cxl_slbia(struct mm_struct *mm); > +void cxl_ctx_get(void); > +void cxl_ctx_put(void); > +bool cxl_ctx_in_use(void); > + > +#else /* CONFIG_CXL_BASE */ > + > +#define cxl_slbia(...) do { } while (0) > +#define cxl_ctx_in_use(...) false Any reason these shouldn't be static inlines? cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/